ENH: Add support for decompiling if-statements. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| takewhile(op.is_not(instr.arg), queue) | ||
| ) | ||
| ) | ||
| if stack_effect_until_target == 0: |
There was a problem hiding this comment.
I would invert this check, if not eq 0, then raise
There was a problem hiding this comment.
This is temporary logic anyway. The other case is ternary/short-circuiting operators.
|
I don't understand why travis isn't running the tests for prs anymore |
|
lgtm though |
ssanderson
pushed a commit
that referenced
this pull request
Dec 11, 2015
ENH: Add support for decompiling if-statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly interesting because it's tricky to tell the difference between an
ifstatement and a short-circuiting operator or a ternary. The key to figuring out that we're in an if statement is looking at the cumulative stack effect between a jump and its target. It's zero only when we're in a jump generated by anif.