[FIX] typo #74
Closed
[FIX] typo #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosa-odoo
commented
Feb 25, 2024
yosa-odoo
commented
```py >>> co = Code.from_pycode(add.__code__) Traceback (most recent call last): File "<stdin>", line 1, in <module> NameError: name 'add' is not defined ``` ```py >>> co = Code.from_pycode(add2.__code__) >>> ```
Issue: As from PEP 604, Union Type Object has been introduced; the `__or__` method has been added to support `X | Y` syntax and in some cases it may override a metaclass `__or__` implementation Solution: Use the `or` operator directly
Positional-Only Parameter has been introduced in Python3.8 (PEP 570) Abstract of the PEP: > This PEP proposes to introduce a new syntax, /, for specifying positional-only parameters in Python function definitions. > Positional-only parameters have no externally-usable name. When a function accepting positional-only parameters is called, positional arguments are mapped to these parameters based solely on their order.
|
Will make sure everything work as from Python 3.10 before proposing something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.