-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code object #9
Code object #9
Conversation
@@ -13,6 +42,15 @@ def __get__(self, instance, owner): | |||
return self._op | |||
|
|||
|
|||
def _notimplemented_property(name): | |||
@property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shame you can't do this as property(abstractmethod(lamba self: raise NotImplementedError(...)))
If there are no more comments, then I would like to merge this. We can always do some post-commit review |
Is there something else that you want to work on that requires these changes? I'm not going to have time to finish looking at this for a couple days at least. |
I was just about to open an API design issue. Also, I got the inline compose working but it requires this. I don't think that particular code should be in here (maybe a recipe). I guess this can stay open while we discuss the new API; however, once we have a solid idea, I would like to work on it with these changes applied. |
No description provided.