Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc uses .osz instead of .osr #52

Closed
InvisibleSymbol opened this issue Aug 23, 2019 · 1 comment · Fixed by #53
Closed

doc uses .osz instead of .osr #52

InvisibleSymbol opened this issue Aug 23, 2019 · 1 comment · Fixed by #53

Comments

@InvisibleSymbol
Copy link
Contributor

https://llllllllll.github.io/slider/replays

*.osz are Executable beatmap files.
You want *.osr if you're talking about replays

Also the path is wrong, it's osu!/data/r, not osu!/r.

@llllllllll
Copy link
Owner

Thanks for noticing this. I believe it is just an issue in the docs, the replay parsing code properly accepts osr files. This is confusing, so the docs do need to be updated. Would you be interested in opening a pull request to fix this? The docs are located in this repo itself, in docs/source (this particular file is docs/source/replays.rst). The docs are written in restructured text, using sphinx, but for for a small change you should just be able to edit the file as plain text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants