Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Automatically create folders #2746

Closed
1 task done
fevolq opened this issue Apr 11, 2024 · 2 comments
Closed
1 task done

[Feature Request]: Automatically create folders #2746

fevolq opened this issue Apr 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@fevolq
Copy link

fevolq commented Apr 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

image
If the path configured in config.txt does not exist, automatically create the corresponding folder instead of using the default path, e.g., ../models/embeddings/.
Otherwise,

  1. It may give the illusion that the configuration in config.txt is ineffective.
  2. When starting based on Docker and if mounting is required, all folders need to be pre-created on the host machine.

Proposed workflow

By default, automatic creation can be enabled.
Alternatively, use an environment variable to control whether automatic creation is enabled or not.

Additional information

No response

@fevolq fevolq added enhancement New feature or request triage This needs an (initial) review labels Apr 11, 2024
@mashb1t mashb1t removed the triage This needs an (initial) review label Apr 13, 2024
@xynydev
Copy link
Contributor

xynydev commented Apr 24, 2024

I ran into the issue where it seemed like I had to manually create the folders with Docker. Using instead of a bind mount a volume, as is suggested by the documentation, the issue disappeared and the folders were automatically created.

@fevolq
Copy link
Author

fevolq commented Apr 26, 2024

If you only created the models folder on the host and mounted it (e.g. -v ${PATH}/models:/app/data/models), then only the checkpoints and loras folders will exist within the models folder. Other folders under /app/data/models (such as embeddings) will not be present in ${PATH}/models.

@mashb1t mashb1t closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants