Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: facial restoration #2796

Open
1 task done
LiveFreeDead opened this issue Apr 23, 2024 · 3 comments
Open
1 task done

[Feature Request]: facial restoration #2796

LiveFreeDead opened this issue Apr 23, 2024 · 3 comments
Labels
enhancement (external) New feature or request to integrate external libraries / tools

Comments

@LiveFreeDead
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do?

Based on this 【much needed】 facial restoration integrated into Fooocus #293

I still think it needs to have the option of codeformer, to allow it to be used for Photo Restorations, the method mentioned in the existing thread changes the face to other people.

Proposed workflow

Original Concept preposed, but maybe you could get away with a check box saying keep Identity (can still apply skin cleanups, define hair etc, but keeping it closer to the source than the current method allows (it really does change the face a lot, even when you set it to 1 and 0 in the weights).

Additional information

Just try it out on one of your own family photos or even a selfie and you'll see what i mean.

@LiveFreeDead LiveFreeDead added enhancement New feature or request triage This needs an (initial) review labels Apr 23, 2024
@ILikeToasters
Copy link

Just want to mention you can use the improve detail feature with Faceswap.

@mashb1t mashb1t changed the title [Feature Request]: 【much needed】 facial restoration integrated into Fooocus #293 is needed [Feature Request]: facial restoration May 2, 2024
@mashb1t mashb1t removed the triage This needs an (initial) review label May 2, 2024
@mashb1t
Copy link
Collaborator

mashb1t commented May 2, 2024

@LiveFreeDead I'm really not certain if this can improve the images as much as inpainting. Leaving this as enhancement for now, but just wanted to let you know that prio is very low here.

@mashb1t mashb1t added enhancement (external) New feature or request to integrate external libraries / tools and removed enhancement New feature or request labels May 2, 2024
@DavidDragonsage
Copy link
Contributor

For appeal to new or casual users, I do think that the inclusion of GFPGAN and Codeformer would fit into the user friendly philosophy of Fooocus. I absolutely agree that Inpainting creates much better results, but this ideal of instant face fixing would be attractive to many people.

I remember that it took quite a while before my wife was comfortable with Inpainting, although she is an accomplished visual artist. She had started with AUTOMATIC1111 and so she was used to the instant results with GFPGAN and Codeformer. She really appreciated switching to Fooocus for its speed and uncluttered interface, but she certainly missed those two features, as well as Reactor quality face swapping.

She has since put a huge amount of time into Fooocus and the quality of Fooocus Inpainting has become one her favourite features. When she does use non-Stable Diffusion generators, the images almost always end up in Fooocus for finishing with Inpainting.

However, there are many Fooocus users without that level of artistic commitment (like my wife) or technical interest (like me). So for that audience, so called "facial restoration" would be a benefit.

But I agree, Manuel, this issue should probably be quite low priority. While I really enjoy using Fooocus, there are so many other aspects that could be improved with relatively little effort - or indeed are complete but waiting in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement (external) New feature or request to integrate external libraries / tools
Projects
None yet
Development

No branches or pull requests

4 participants