ドキュメントの修正 #45
Merged
ドキュメントの修正 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maekawataiki
commented
Jan 22, 2024
maekawataiki
commented
- デプロイコマンドのドキュメントの修正
- cdk:watch コマンドの修正とドキュメントのアップデート
icoxfog417
reviewed
Jan 22, 2024
| 環境を指定する際は、`-c` で `stage` を使用してください。 | ||
|
|
||
| ```bash | ||
| npm run cdk:watch -- -c stage=<stage> |
There was a problem hiding this comment.
package.jsoin で cdk:watch が npm -w packages/cdk run cdk watch -- まで登録されていますが、その状態でも -- 必要そうでしょうか? (-c stage=<stage> だけでよいかなと)
There was a problem hiding this comment.
ややこしいですが、
最初のコマンドにある -- は npm run ではなく package.json に登録されている scripts の cdk:watch に渡すための引数であること示しています。
scripts の cdk:watch にある -- は npm -w packages/cdk run ... の引数ではなく cdk watch に渡すための引数であることを示しています。
両方指定しないと最後の cdk watch に引数が渡されません。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.