Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blt_add_benchmark should take CONFIGURATIONS and OMP_NUM_THREADS arguments #635

Closed
skyreflectedinmirrors opened this issue May 17, 2023 · 4 comments

Comments

@skyreflectedinmirrors
Copy link

E.g., here:

CONFIGURATIONS Benchmark)

Not only is this consistent with blt_add_test, but this enables e.g., creating your own configurations that specific benchmarks should be run on. For instance, I would like to create a "Multinode" configurations where only tests / benchmarks that require multiple nodes should be run (e.g., to benchmark inter-node bandwidth). This way I can create a Jenkins job or the like that only runs those tests when I allocate two+ nodes for a job.

Today, I have to do something like:

blt_add_test(...
                    CONFIGURATIONS Benchmark Multinode
)

I think this would be a minimally invasive PR, and I'd be happy to work on it if y'all agree.

@skyreflectedinmirrors
Copy link
Author

Looking at it, it appears that NUM_OMP_THREADS is missing as well

@white238
Copy link
Member

That's a great idea. We appreciate any help if you have time, otherwise I will handle it shortly.

@skyreflectedinmirrors
Copy link
Author

started in #636

@skyreflectedinmirrors skyreflectedinmirrors changed the title blt_add_benchmark should take CONFIGURATIONS argument blt_add_benchmark should take CONFIGURATIONS and OMP_NUM_THREADS arguments May 17, 2023
@white238
Copy link
Member

white238 commented Jun 6, 2023

Closed in #636

@white238 white238 closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants