Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug related to subsets partition #51

Closed
oooo1114 opened this issue Jun 5, 2024 · 1 comment
Closed

Bug related to subsets partition #51

oooo1114 opened this issue Jun 5, 2024 · 1 comment

Comments

@oooo1114
Copy link

oooo1114 commented Jun 5, 2024

Hello,
In class subsetParameters and function breakIntoSubsets, subsets are defined like g[m:-1:numSubsets,:,:].
However, for the last subset, the last element will be dropped in python, which makes an inconsistent subset.
For example,

x = range(16)
print(list(x[3:-1:4]))

gives [3, 7, 11].

@kylechampley
Copy link
Collaborator

You are absolutely correct, thanks for pointing this out!

I found and fixed this issue in the breakIntoSubsets function and the subsetParameters class. If you want early access to these changes, you can pull from the champley_dev branch. Otherwise this'll get merged into the main branch for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants