Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to start a PR for adding support for KPa, MPa, GPa but permission denied #281

Closed
ruihuasun opened this issue Mar 10, 2023 · 3 comments
Closed

Try to start a PR for adding support for KPa, MPa, GPa but permission denied #281

ruihuasun opened this issue Mar 10, 2023 · 3 comments

Comments

@ruihuasun
Copy link

Like the title says.
@phlptp
Copy link
Collaborator

phlptp commented Mar 10, 2023

How are you trying this, there should be no restrictions on creating a PR from a fork.
And what isn't working in regard to those units. MPa and GPa should be pretty standard SI prefixes to Pascals

@ruihuasun
Copy link
Author

@phlptp Sorry for this unnecessary issue. Cool for SI prefixes. I didn't see GPa in the help, so I thought it didn't support GPa,...

@phlptp
Copy link
Collaborator

phlptp commented Mar 10, 2023

The library should support nearly all units I can find reference to and all SI prefixes, But if you find one that doesn't feel free to add it or let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phlptp @ruihuasun