-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the URL of the Thunderstore.io API call to get BepInExPack (fixes #665) #666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked that this works.
I have nothing meaningful to contribute other than to point out this is the "PR of the Beast" (#666) :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same error. If I make a manual adjustment in docker container, according to the uploaded patch, the problem is solved.
Yes, full transparency; I had an error when trying to build the docker image, but I figured it either needed some configuration or had something to do with the fact that I'm on windows, and I was too lazy to troubleshoot that for a URL change😄 So I just docker exec'd into the container and edited bepinex updater with vim and restarted the container and boom, it worked. The bepinex updater can be found in |
Yea i changed the url to https://thunderstore.io/api/experimental/package/denikson/BepInExPack_Valheim/ using vim and now my server works again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After changing this in my own server it worked. So this is the solution..
Guys, can You push this commit to prod? I`m using CasaOS to run the server, changed link via nano, but still server stuck on this error, even after restarts of container\server. |
As a workaround, you could pull the repo down locally, make the changes, and run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also tested this and it works.
Please tell me in more detail how I can change the address? I can’t get access to BepInEx updater UPD. |
Can you please point me in the right direction? I'm struggling to figure this out, thanks. UPD: I also fixed this myself, hurrah! |
I apparently can't google as I can't locate the updater file to modify. Any clues to get me down the right path? |
Thank you for that info... I, in my true noob self, was looking for the container files within my portainer install images instead of running the container console..... Works like a charm now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works. BepInExPack moved to new address https://thunderstore.io/api/experimental/package/denikson/BepInExPack_Valheim/
tested
is the maintainer gone or is he waiting till ashelands? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can confirm that this fix works.
|
Thanks a lot @erNail, been wanting to write that but I was too lazy to be honest 😄 I'd like to add a bit of clarification on 4 and 5.
Happy gaming |
https://github.com/users/russwe/packages/container/valheim-server-docker If you just need to pull a container and be done. More than happy to MR some of the changes/tweaks back if desired, and quite happy to shut mine down once the fix is in ^_^ |
Bumping for attention, can confirm this PR fixes the |
Also confirming it works! I built this and pushed it to my docker hub if anyone wants to use it: clarkent86/valheim-server |
Can a reviewer have a quick look at this PR ? |
Does anybody beside @lloesche have review/merge rights ? |
Im trying to change the url in bepinex-updater, and get The last line repeats it self. The server can't be seen in the server list. Any suggestion? Edit 17th of April. After much head scratching, my linux bistro didn't want to play with me anymore, so I had to scrap the VM and set up everything from zero. Very happy I have backups and documentation on my build, so it was a bit easier this time around. Now the edit works, and so do BepinEx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm this solved me issue
I see him committing stuff on other things Not sure he cares about this project. He needs another reviewer incase something happens to him. |
@a-sala7 thank you for your PR! Hey all, sorry for the late reply. I haven't played Valheim in over a year, so rarely check here. There are four other collaborators with commit access on this repo, but I guess they're in the same boat. I'm open to adding additional active collaborators. Let me know if you have a good understanding of the components this repo is made up of (Docker, Go, Python, Bash) and I'll add you. Again sorry for the delay. |
@lloesche of course man it's totally understandable, no worries. |
Thanks 👍 |
Edit:
For a temporary manual fix until this PR is merged and the image is updated, please check @erNail's comment here
#666 (comment)