Add aarch64 SIMD specialization #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llogiq
force-pushed
the
aarch64
branch
4 times, most recently
from
7201a6f
to
c815bee
Compare
|
There are still failing tests on aarch64. Notably the |
|
Am I good to wait for the tests to be fixed before reviewing, or would you prefer a review sooner? |
|
Yeah, I need to find a few hours. I think I know what's wrong, just need to fix things. I'll ping you. |
|
@Veedrac if all goes well, CI should be green soon. I've checked that perf matches the packed_simd variant on a M2 macbook and my mobile phone (using the bootstrap trick). |
|
@Veedrac CI is most certainly green. I'm tempted to just bump the version, push and publish it. |
|
I'm going to merge this now; it's fared well in all my tests, and if there's anything wrong, we can fix it in a followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still without a good ARM CPU (but will hopefully get one, soon), but here's what I think should likely be the aarch64 intrinsics version of bytecount.
@Veedrac if you have a bit of time, I'd appreciate a review.