Replace the combination of IsNot and Matches with Mismatches #164

src/main/java/org/llorllale/cactoos/matchers/package-info.java

@@ -28,10 +28,6 @@
 /**
  * An extension of cactoos with object-oriented hamcrest matchers.
  *
- * @todo #136:30m Replace the combination of IsNot and Matches with Mismatches.
- *  This combination does not check textual output of Matcher, only boolean
- *  value. It's up for discussion if checking the output is too exhaustive or
- *  not, leave a comment to this task clarify that.
  * @since 0.14
  */
 package org.llorllale.cactoos.matchers;

src/test/java/org/llorllale/cactoos/matchers/IsTrueTest.java

@@ -49,9 +49,9 @@ void matchPositive() {
     }
 
     @Test
-    void describesCorrectly() {
+    void matchNegative() {
         new Assertion<>(
-            "must throw an exception that describes the values",
+            "mismatches 'false'",
             new IsTrue(),
             new Mismatches<>(
                 false,

src/test/java/org/llorllale/cactoos/matchers/RunsInThreadsTest.java

@@ -31,7 +31,6 @@
 import org.cactoos.Func;
 import org.cactoos.func.Repeated;
 import org.hamcrest.core.IsEqual;
-import org.hamcrest.core.IsNot;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -83,8 +82,8 @@ void matchNegative() {
         ).affirm();
         new Assertion<>(
             "counter must not be incremented by all threads",
-            counter.get(),
-            new IsNot<>(new IsEqual<>(threads * attempts))
+            counter.get() < threads * attempts,
+            new IsEqual<>(true)
         ).affirm();
     }
 

src/test/java/org/llorllale/cactoos/matchers/ThrowsTest.java

@@ -33,7 +33,6 @@
 import org.hamcrest.Description;
 import org.hamcrest.StringDescription;
 import org.hamcrest.core.IsEqual;
-import org.hamcrest.core.IsNot;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -72,7 +71,14 @@ void matchNegative() {
         new Assertion<>(
             "mismatches scalar that doesn't throw any exception",
             new Throws<>("illegal arg", IllegalArgumentException.class),
-            new IsNot<>(new Matches<>(() -> "no exception"))
+            new Mismatches<>(
+                new ScalarOf<>(
+                    () -> "no exception"
+                ),
+                "Exception has type 'java.lang.IllegalArgumentException'"
+                    + " and message matches \"illegal arg\"",
+                "The exception wasn't thrown."
+            )
         ).affirm();
     }
 
@@ -97,14 +103,16 @@ void mismatchException() {
             // @checkstyle LineLength (1 line)
             "mismatches if exception thrown is not subtype of expected exception",
             new Throws<>("", IOException.class),
-            new IsNot<>(
-                new Matches<>(
-                    new ScalarOf<>(
-                        () -> {
-                            throw new IllegalArgumentException("");
-                        }
-                    )
-                )
+            new Mismatches<>(
+                new ScalarOf<>(
+                    () -> {
+                        throw new IllegalArgumentException("");
+                    }
+                ),
+                "Exception has type 'java.io.IOException'"
+                    + " and message matches \"\"",
+                "Exception has type 'java.lang.IllegalArgumentException'"
+                    + " and message ''"
             )
         ).affirm();
     }