(#243) Qulice compliance

llorllale · May 13, 2021 · 7abf3fc · 7abf3fc
1 parent 12b8640
commit 7abf3fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/src/main/java/org/llorllale/cactoos/matchers/IsBytes.java b/src/main/java/org/llorllale/cactoos/matchers/IsBytes.java
@@ -91,11 +91,11 @@ protected boolean matchesSafely(
         final byte[] presented = new UncheckedBytes(item).asBytes();
         final byte[] expected = this.bytes.asBytes();
         final boolean result;
-        if (!Arrays.equals(presented, expected)) {
+        if (Arrays.equals(presented, expected)) {
+            result = true;
+        } else {
             description.appendValue(new IterableOfBytes(presented));
             result = false;
-        } else {
-            result = true;
         }
         return result;
     }

diff --git a/src/test/java/org/llorllale/cactoos/matchers/IsBytesTest.java b/src/test/java/org/llorllale/cactoos/matchers/IsBytesTest.java
@@ -26,7 +26,6 @@
  */
 package org.llorllale.cactoos.matchers;
 
-import org.cactoos.Text;
 import org.cactoos.bytes.BytesOf;
 import org.cactoos.bytes.HexOf;
 import org.cactoos.text.TextOf;
@@ -37,13 +36,12 @@
  * @since 1.0.0
  * @checkstyle MagicNumberCheck (500 lines)
  */
-@SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class IsBytesTest {
 
     @Test
     void matchesExactly() {
         new Assertion<>(
-            "Must match",
+            "Must match with chars",
             new BytesOf("ABC"),
             new IsBytes('A', 'B', 'C')
         ).affirm();
@@ -52,7 +50,7 @@ void matchesExactly() {
     @Test
     void mismatches() {
         new Assertion<>(
-            "Must mismatch",
+            "Must mismatch with bytes",
             new IsBytes((byte) 65, (byte) 66, (byte) 67),
             new Mismatches<>(
                 new BytesOf("abc"),
@@ -65,7 +63,7 @@ void mismatches() {
     @Test
     void matchesAsString() {
         new Assertion<>(
-            "Must match",
+            "Must match with String",
             new HexOf(new TextOf("6465616462656166")),
             new IsBytes("deadbeaf")
         ).affirm();