-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MatcherAssert.assertThat with 'new Assertion<>' #18
Comments
@0crat in |
@llorllale Job #18 is now in scope, role is |
Bug was reported, see §29: +15 point(s) just awarded to @llorllale/z |
@llorllale let's make It would thus look like this for normal execution flow: new Assertion<>(
"Collection cannot be empty",
() -> collection.size(),
new IsNot<>(0)
).verify(); //might throw AssertionError To test for exceptions, one would perhaps just provide a matcher for the exception: new Assertion<>(
"Collection cannot be empty",
() -> collection.size(),
new Throws(IllegalArgumentException.class, "Illegal size") // exception matcher
).verify(); //might throw AssertionError See ##40 (comment) |
@0crat assign me |
* Added `Assertion` * `Throws` now declares a generic parameter in order to be compatible with `Assertion` * Left puzzle to refactor existing tests with `Assertion` * Left puzzle to continue refining `Assertion`
@llorllale @llorllale/z not enough funds available in the project, can't set budget of job #18, see §21; @llorllale/z will get no money on completion; in order to fix that, add funds to the project and assign the job again |
Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @llorllale/z |
It is strongly discouraged to assign jobs to their creators, see §19: -15 point(s) just awarded to @llorllale/z |
* Added `Assertion` * `Throws` now declares a generic parameter in order to be compatible with `Assertion` * Left puzzle to refactor existing tests with `Assertion` * Left puzzle to continue refining `Assertion`
* Added `Assertion` * `Throws` now declares a generic parameter in order to be compatible with `Assertion` * Left puzzle to refactor existing tests with `Assertion` * Left puzzle to continue refining `Assertion`
@llorllale 2 puzzles #52, #53 are still not solved. |
@llorllale |
Job #18 is not in the agenda of @llorllale/z, can't retrieve data and time of add |
Job was finished in 2 hours, bonus for fast delivery is possible (see §36) |
The job #18 is now out of scope |
Order was finished: +35 point(s) just awarded to @llorllale/z |
@llorllale 3 puzzles #53, #80, #81 are still not solved; solved: #52. |
@rultor release, tag is |
@llorllale OK, I will release it now. Please check the progress here |
@llorllale Done! FYI, the full log is here (took me 19min) |
Let's add a substitute for
MatcherAssert.assertThat
, something likeAssertion<T>
:Note: ctor must have the reason text parameter
The text was updated successfully, but these errors were encountered: