Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeeInputHasResult.java:46-48: Delete TeeInputHasResult... #68

Closed
0pdd opened this issue Jan 3, 2019 · 18 comments
Closed

TeeInputHasResult.java:46-48: Delete TeeInputHasResult... #68

0pdd opened this issue Jan 3, 2019 · 18 comments
Labels
bug Something isn't working pdd
Milestone

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 3, 2019

The puzzle 58-b44e1a44 from #58 has to be resolved:

* @todo #58:30min Delete TeeInputHasResult from the library. It's too specific.
* Users should use InputHasContent instead. Should be moved to test packages
* in cactoos.

The puzzle was created by @rultor on 03-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 3, 2019

This puzzle inherited milestone 1.0.0 from issue #58.

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

Job #68 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Mar 2, 2019

The job #68 assigned to @fabriciofx/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@llorllale
Copy link
Owner

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

@0crat refuse (here)

@llorllale The user @fabriciofx/z resigned from #68, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Mar 30, 2019

The job #68 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator

@llorllale what does Should be moved to test packages in cactoos mean here? What should be moved to cactoos?

@victornoel
Copy link
Collaborator

@llorllale see my comment above

@llorllale llorllale added this to the 1.0.0 milestone Apr 2, 2019
@llorllale
Copy link
Owner

@victornoel good question. Not sure what I was thinking at the time.

If "users should use InputHasContent", then TeeInputHasResult should not be moved to cactoos at all - it should be deleted and replaced by InputHasContent.

Looks to me like all that's left to do in cactoos-matchers is to delete TeeInputHasResult. cactoos will have to refactor later on when upgrading version.

victornoel added a commit to victornoel/cactoos-matchers that referenced this issue Apr 2, 2019
@victornoel
Copy link
Collaborator

@0crat wait for #104 to be merged.

@llorllale once #104 is merged I think we can release a new version and I can take care of updating cactoos-matchers in cactoos as part of this issue since there wasn't so much work here to do. Or we can wait for #103 maybe, you tell me :)

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2019

@0crat wait for #104 to be merged. @llorllale once #104 is merged I think we can release a new... (here)

@victornoel The impediment for #68 was registered successfully by @victornoel/z

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 6, 2019

The puzzle 58-b44e1a44 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Apr 6, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 6, 2019

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2019

The job #68 is now out of scope

@sereshqua
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

No branches or pull requests

5 participants