(#20) Cleanup matcher #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
============================================
+ Coverage 98.83% 98.86% +0.02%
- Complexity 142 147 +5
============================================
Files 28 28
Lines 343 352 +9
Branches 4 7 +3
============================================
+ Hits 339 348 +9
Misses 4 4
Continue to review full report at Codecov.
|
victornoel
force-pushed
the
cleanup-matcher
branch
2 times, most recently
from
a940952
to
aabcfa7
Compare
baudoliver7
suggested changes
Feb 14, 2021
| @@ -46,7 +47,7 @@ | |||
| * @since 0.24 | |||
| * @checkstyle JavadocMethodCheck (500 lines) | |||
| */ | |||
| public final class RunsInThreads<T> extends TypeSafeMatcher<Func<T, Boolean>> { | |||
| public final class RunsInThreads<T> extends TypeSafeDiagnosingMatcher<Func<? super T, Boolean>> { | |||
There was a problem hiding this comment.
@victornoel I think it isn't necessary to use ? super T in TypeSafeDiagnosingMatcher<Func<? super T, Boolean>>. Just T would be enough.
There was a problem hiding this comment.
@baudoliver7 yep, I suppose it's not really needed here, I will remove it to not make things over complex
| @@ -58,41 +54,15 @@ void matches() { | |||
| * Gives negative testing result for the invalid arguments. | |||
| */ | |||
| @Test | |||
| void matchStatus() { | |||
| void mismatches() { | |||
There was a problem hiding this comment.
@victornoel What about the match case.
There was a problem hiding this comment.
@baudoliver7 I will suppose you mean testing Matches using Matches? it's a good idea
victornoel
force-pushed
the
cleanup-matcher
branch
from
aabcfa7
to
fd1071e
Compare
|
@baudoliver7 thank you, it's done |
|
@victornoel thx, looks good to me :) |
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Oops, I failed. You can see the full log here (spent 4min) |
victornoel
force-pushed
the
cleanup-matcher
branch
from
fd1071e
to
9e2eb26
Compare
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Oops, I failed. You can see the full log here (spent 9min) |
victornoel
force-pushed
the
cleanup-matcher
branch
from
9e2eb26
to
ce70d22
Compare
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 10min) |
|
Job was finished in 24 hours, bonus for fast delivery is possible (see §36) |
|
@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality acceptable |
|
@baudoliver7 please make sure you will find at least 3 issues during next CR, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #20 that was incorrectly closed.