Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IsBlank operate on Text #247

Merged
merged 3 commits into from Jun 27, 2021
Merged

Make IsBlank operate on Text #247

merged 3 commits into from Jun 27, 2021

Conversation

andreoss
Copy link
Contributor

  • Make IsBlank match Text object

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #247 (5cadc02) into master (37cac65) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
+ Coverage     98.95%   99.05%   +0.09%     
- Complexity      150      162      +12     
============================================
  Files            28       36       +8     
  Lines           383      422      +39     
  Branches          7        8       +1     
============================================
+ Hits            379      418      +39     
  Misses            4        4              
Impacted Files Coverage Δ
...n/java/org/llorllale/cactoos/matchers/IsBlank.java 100.00% <100.00%> (ø)
.../java/org/llorllale/cactoos/matchers/IsNumber.java 100.00% <0.00%> (ø)
...lorllale/cactoos/matchers/IsComparableEqualTo.java 100.00% <0.00%> (ø)
...actoos/matchers/IsComparableLessThanOrEqualTo.java 100.00% <0.00%> (ø)
...rg/llorllale/cactoos/matchers/NaturalOrdering.java 100.00% <0.00%> (ø)
...n/java/org/llorllale/cactoos/matchers/IsBytes.java 100.00% <0.00%> (ø)
...g/llorllale/cactoos/matchers/NumberComparator.java 100.00% <0.00%> (ø)
...oos/matchers/IsComparableGreaterThanOrEqualTo.java 100.00% <0.00%> (ø)
...orllale/cactoos/matchers/IsComparableLessThan.java 100.00% <0.00%> (ø)
...lale/cactoos/matchers/IsComparableGreaterThan.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cac65...5cadc02. Read the comment docs.

@andreoss andreoss changed the title Make IsBlank make on Text Make IsBlank operate on Text May 14, 2021
@victornoel
Copy link
Collaborator

@0crat status

1 similar comment
@victornoel
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator

@0crat in

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2021

@victornoel/z everybody who has role REV is banned at #247; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented Jun 24, 2021

@victornoel/z everybody who has role REV is banned at #247; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Copy link
Collaborator

@victornoel victornoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreoss thx, here is a review

src/main/java/org/llorllale/cactoos/matchers/IsBlank.java Outdated Show resolved Hide resolved
@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 27, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 182afdc into llorllale:master Jun 27, 2021
@rultor
Copy link
Collaborator

rultor commented Jun 27, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

@0crat 0crat removed the 0crat/scope label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants