Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message always failed #49

Closed
scrobot opened this issue Jul 22, 2019 · 1 comment
Closed

Commit message always failed #49

scrobot opened this issue Jul 22, 2019 · 1 comment

Comments

@scrobot
Copy link

scrobot commented Jul 22, 2019

I integrated go-gitlint in my cactoos fork, I tried to commit a few times with some commit message variants, but always I got

fakehsh: subject does not match regex [^\(#[0-9]+\) [^\s].{13,50}]

I suppose, that maybe regex has the wrong signature. Because of the simplest commit message, like

(yegor256#1141) Code review: fix gitlint errors for merge with rutor

is not passing through regular expression. I tried some previous commits messages, but they are not passing too.

@llorllale
Copy link
Owner

@scrobot I can tell you for sure that (yegor256#1141) would never match the regex because ^\(#[0-9]+\) expects the # character right after the opening parenthesis

@scrobot scrobot closed this as completed Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants