Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload.java:45-47: The following configurations must be... #14

Closed
0pdd opened this issue Mar 16, 2018 · 4 comments · Fixed by #15
Closed

Upload.java:45-47: The following configurations must be... #14

0pdd opened this issue Mar 16, 2018 · 4 comments · Fixed by #15
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@0pdd
Copy link

0pdd commented Mar 16, 2018

The puzzle 5-b8c640d1 from #5 has to be resolved:

releasecat-maven-plugin/src/main/java/org/llorllale/mvn/plgn/releasecat/Upload.java

Lines 45 to 47 in 5e4f74f

* @todo #5:15min The following configurations must be marked as required: token, user, repo, tag.
* 'Token' is used to authenticate against GitHub'; 'user' is the user to whom the project belongs
* to; 'repo' is the name of the project; 'tag' is the name of the tag to apply to the release.

The puzzle was created by George Aristy on 16-Mar-18.

Estimate: 15 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Mar 16, 2018
@llorllale
(#5) Added configuration and upload of files (#12)
5e4f74f 
* New composite configuration 'asset' with 3 properties:
  - name of the asset
  - type of the asset (mime type)
  - file
* Excluded new 'Asset' class from cobertura because it was lowering the
  test coverage. Besides, it is just a plain DTO.
This was referenced Mar 16, 2018
Closed
Closed
@llorllale llorllale added the bug Something isn't working label Mar 16, 2018
@llorllale llorllale added this to the 1.0.0 milestone Mar 16, 2018
llorllale added a commit that referenced this issue Mar 16, 2018
@llorllale
(#14) Made required configurations: token, repo, user, and tag
efa25b6
@llorllale llorllale mentioned this issue Mar 16, 2018
Merged
llorllale added a commit that referenced this issue Mar 16, 2018
@llorllale
(#14) Made required configurations: token, repo, user, and tag (#15)
491d588
This was referenced Mar 16, 2018
Closed
Closed
@0pdd
Copy link
Author

0pdd commented Mar 16, 2018

@0pdd 2 puzzles #16, #17 are still not solved.

@0pdd
Copy link
Author

0pdd commented Mar 19, 2018

@0pdd 2 puzzles #16, #19 are still not solved; solved: #17.

@0pdd
Copy link
Author

0pdd commented Apr 12, 2018

@0pdd the puzzle #16 is still not solved; solved: #17, #19.

@0pdd
Copy link
Author

0pdd commented May 13, 2018

@0pdd all 3 puzzles are solved here: #16, #17, #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

(#14) Made required configurations: token, repo, user, and tag llorllale/releasecat-maven-plugin
2 participants
@llorllale @0pdd