Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

(#117) Refactor EntrySpec #118

Merged
merged 2 commits into from Dec 20, 2017
Merged

(#117) Refactor EntrySpec #118

merged 2 commits into from Dec 20, 2017

Conversation

llorllale
Copy link
Owner

(NEW) Xml interface
(NEW) Xml.asString()
(NEW) MockTimeTrackEntryType
(NEW) EntrySpec overloaded constructors
(NEW) EntrySpec.equals() and hashCode()
(NEW) TimeTrackEntrypType.equals() and hashCode()
(REF) IssueSpec: no longer holding nullable attributes inside
        an Optional
(REF) EntrySpec.asHttpEntity() renamed to EntrySpec.asXml()
(REF) XmlObject renamed to XmlOf (implements Xml)
(REF) StringAsDocument: now throwing UncheckedException instead
        of ParseException
(REF) XmlObjects renamed to XmlsOf (implements Collection<Xml>)
(FIX) Missing unit tests for EntrySpec
(DEL) ParseException: no longer used. It was being used in places
         where UncheckedException is appropriate.
(DEL) EntrySpec.with(Field, FieldValue): substituted by new
         constructor overloads

closes #117

(NEW) Xml interface
(NEW) Xml.asString()
(NEW) MockTimeTrackEntryType
(NEW) EntrySpec overloaded constructors
(NEW) EntrySpec.equals() and hashCode()
(NEW) TimeTrackEntrypType.equals() and hashCode()
(REF) IssueSpec: no longer holding nullable attributes inside
      an Optional
(REF) EntrySpec.asHttpEntity() renamed to EntrySpec.asXml()
(REF) XmlObject renamed to XmlOf (implements Xml)
(REF) StringAsDocument: now throwing UncheckedException instead
      of ParseException
(REF) XmlObjects renamed to XmlsOf (implements Collection<Xml>)
(FIX) Missing unit tests for EntrySpec
(DEL) ParseException: no longer used. It was being used in places
      where UncheckedException is appropriate.
(DEL) EntrySpec.with(Field, FieldValue): substituted by new
      constructor overloads
@llorllale llorllale added this to the 1.0.0 milestone Dec 20, 2017
@llorllale llorllale self-assigned this Dec 20, 2017
(FIX) Bug in DefaultUpdateIssue.field(Field, FieldValue): forgot
      to add the given field+value to the issue spec used to
      udpate the issue
@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

Merging #118 into master will increase coverage by 1.41%.
The diff coverage is 90.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #118      +/-   ##
=========================================
+ Coverage   89.49%   90.9%   +1.41%     
=========================================
  Files          49      48       -1     
  Lines         676     704      +28     
  Branches       30      32       +2     
=========================================
+ Hits          605     640      +35     
+ Misses         63      56       -7     
  Partials        8       8
Impacted Files Coverage Δ
...java/org/llorllale/youtrack/api/DefaultFields.java 100% <ø> (ø) ⬆️
...va/org/llorllale/youtrack/api/DefaultComments.java 100% <ø> (ø) ⬆️
...in/java/org/llorllale/youtrack/api/XmlComment.java 100% <ø> (ø) ⬆️
...in/java/org/llorllale/youtrack/api/XmlProject.java 84.21% <ø> (ø) ⬆️
...va/org/llorllale/youtrack/api/XmlUsersOfIssue.java 100% <ø> (ø) ⬆️
...main/java/org/llorllale/youtrack/api/XmlIssue.java 94.28% <100%> (+0.73%) ⬆️
.../llorllale/youtrack/api/XmlTimeTrackEntryType.java 100% <100%> (ø) ⬆️
...c/main/java/org/llorllale/youtrack/api/XmlsOf.java 100% <100%> (ø)
...va/org/llorllale/youtrack/api/DefaultProjects.java 100% <100%> (ø) ⬆️
...va/org/llorllale/youtrack/api/XmlProjectField.java 100% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3cba93...8c2df27. Read the comment docs.

@llorllale llorllale merged commit ec2e5f8 into master Dec 20, 2017
@llorllale llorllale deleted the 117 branch December 20, 2017 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor EntrySpec
1 participant