-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update circe version for publishing enumeratum-circe on 2.13 (jvm+js) #241
Update circe version for publishing enumeratum-circe on 2.13 (jvm+js) #241
Conversation
5e2d38f
to
387896e
Compare
Add enumeratum circe to project refs
387896e
to
d4c1cd7
Compare
This works for the jvm project, but not js. I'm not super experienced on the js side yet, so that'd be better left to someone that knows how to fix whatever issue is coming up there. |
I'm following up with this on the Circe side to see why it fails with ScalaJS. |
Travis Brown answered my question in circe/circe#945 (comment) Basically 0.12 w/ ScalaJS requires you to bring your own So I think this just needs something like the following .jsSettings(
libraryDependencies += "io.circe" %%% "not-java-time" % "0.2.0" % Test
) added to the end of the Lines 316 to 331 in fabfd5a
|
Thanks for the research @lloydmeta, I went ahead and added your suggestion, but filtered to only modify for 2.13. |
# Conflicts: # build.sbt
a05c102
to
85b0658
Compare
I just retriggered the build via a force-push with no modifications. I'm not sure what caused the prior 2.10 testing error. Looks like this works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! LGTM.
Just released a 2.13 |
Hi, I noticed that enumeratum_circe has not published on 2.13 yet. Circe is available for 2.13 via
0.12.0-M4
. Tests pass on this version without modification.