Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circe version for publishing enumeratum-circe on 2.13 (jvm+js) #241

Merged

Conversation

zakpatterson
Copy link
Contributor

@zakpatterson zakpatterson commented Jul 2, 2019

Hi, I noticed that enumeratum_circe has not published on 2.13 yet. Circe is available for 2.13 via 0.12.0-M4. Tests pass on this version without modification.

@coveralls
Copy link

coveralls commented Jul 2, 2019

Coverage Status

Coverage remained the same at 91.313% when pulling 85b0658 on zakpatterson:update-enumeratum-circe_2.13 into fabfd5a on lloydmeta:master.

Add enumeratum circe to project refs
@zakpatterson
Copy link
Contributor Author

This works for the jvm project, but not js. I'm not super experienced on the js side yet, so that'd be better left to someone that knows how to fix whatever issue is coming up there.

@zakpatterson zakpatterson changed the title Update circe version for publishing enumeratum-circe on 2.13 Update circe version for publishing enumeratum-circe on 2.13 (jvm only) Jul 4, 2019
@lloydmeta lloydmeta mentioned this pull request Jul 5, 2019
@lloydmeta
Copy link
Owner

I'm following up with this on the Circe side to see why it fails with ScalaJS.

@lloydmeta
Copy link
Owner

Travis Brown answered my question in circe/circe#945 (comment)

Basically 0.12 w/ ScalaJS requires you to bring your own java.time._ implementation (in release notes)

So I think this just needs something like the following

.jsSettings(
  libraryDependencies += "io.circe" %%% "not-java-time" % "0.2.0" % Test
)

added to the end of the enumeratumCirce module definition:

enumeratum/build.sbt

Lines 316 to 331 in fabfd5a

lazy val enumeratumCirce = crossProject(JSPlatform, JVMPlatform)
.crossType(CrossType.Pure)
.in(file("enumeratum-circe"))
.settings(commonWithPublishSettings: _*)
.settings(testSettings: _*)
.settings(
name := "enumeratum-circe",
version := "1.5.22-SNAPSHOT",
crossScalaVersions := scalaVersionsAll,
libraryDependencies ++= {
Seq(
"com.beachape" %%% "enumeratum" % Versions.Core.stable,
"io.circe" %%% "circe-core" % theCirceVersion(scalaVersion.value)
)
}
)

@zakpatterson zakpatterson changed the title Update circe version for publishing enumeratum-circe on 2.13 (jvm only) Update circe version for publishing enumeratum-circe on 2.13 (jvm+js) Jul 5, 2019
@zakpatterson
Copy link
Contributor Author

Thanks for the research @lloydmeta, I went ahead and added your suggestion, but filtered to only modify for 2.13.

@zakpatterson
Copy link
Contributor Author

I just retriggered the build via a force-push with no modifications. I'm not sure what caused the prior 2.10 testing error. Looks like this works.

Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM.

@lloydmeta lloydmeta merged commit 85b03ba into lloydmeta:master Jul 8, 2019
@lloydmeta
Copy link
Owner

Just released a 2.13 enumeratum-circe with this change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants