Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change UrlBinder error message to use the enum #310

Merged
merged 1 commit into from
Mar 27, 2021
Merged

change UrlBinder error message to use the enum #310

merged 1 commit into from
Mar 27, 2021

Conversation

sapka12
Copy link
Contributor

@sapka12 sapka12 commented Mar 25, 2021

resolving the following issue: #309

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.219% when pulling 1e05d15 on sapka12:309-urlbinder into d9c1609 on lloydmeta:master.

lloydmeta
lloydmeta approved these changes Mar 27, 2021
View reviewed changes
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks.

@lloydmeta lloydmeta merged commit 63705f5 into lloydmeta:master Mar 27, 2021
@sapka12 sapka12 deleted the 309-urlbinder branch April 14, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloydmeta lloydmeta lloydmeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sapka12 @coveralls @lloydmeta