Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unicode identifiers support #186

Merged
merged 4 commits into from
Jun 19, 2021
Merged

Fix unicode identifiers support #186

merged 4 commits into from
Jun 19, 2021

Conversation

lloydmeta
Copy link
Owner

@lloydmeta
[Fix] Unicode support
37752e5 
1.53 brought unicode support; apparently, we were missing the unicode bookend types.

This fixes that and adds a regression test.
@lloydmeta
* Disable clippy self convention for a method.
293c2f6
@lloydmeta lloydmeta requested review from Centril and ExpHP June 18, 2021 02:46
@lloydmeta lloydmeta self-assigned this Jun 18, 2021
ExpHP
ExpHP previously requested changes Jun 18, 2021
View reviewed changes
tests/common/mod.rs Outdated Show resolved Hide resolved
@lloydmeta lloydmeta requested a review from ExpHP June 18, 2021 04:10
@ExpHP
Copy link
Collaborator

ExpHP commented Jun 18, 2021 •
edited

Hmmm, that unicode "mixed script confusibles" warning is really pesky. :/

Looking at this: https://www.unicode.org/Public/security/13.0.0/confusablesSummary.txt. I guess β (beta) is no good either because it looks like ß? I'm hard pressed to find any character that is not on here...

Maybe we should just #![allow(mixed_script_confusables)] on the file. It is just a test file after all... (and also, the set of confusables can change over time, so I'm not sure if there's really any other way to be robust against this)

@lloydmeta
Copy link
Owner Author

Looks like あ did the trick.

@lloydmeta lloydmeta dismissed ExpHP’s stale review June 18, 2021 09:29

No longer using a confusable unicode char :)

@lloydmeta lloydmeta merged commit b8fa846 into master Jun 19, 2021
@lloydmeta lloydmeta deleted the fix-unicode-identifiers-support branch June 19, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Awaiting requested review from Centril

@ExpHP ExpHP Awaiting requested review from ExpHP

Assignees

@lloydmeta lloydmeta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unicode identifiers Cl failures from clippy
2 participants
@lloydmeta @ExpHP