Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Semigroup for HashSet and HashMap #196

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Optimize Semigroup for HashSet and HashMap #196

merged 4 commits into from
Dec 17, 2021

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Dec 12, 2021

  • Optimize Semigroup for HashSet (union is faster)
  • Optimize Semigroup for HashMap (HashMap::clone is optimized)
  • Prettify code in Semigroup for Option

@kpp
Copy link
Contributor Author

kpp commented Dec 12, 2021

@lloydmeta do you want me to fix clippy issue in this PR?

@lloydmeta
Copy link
Owner

@lloydmeta do you want me to fix clippy issue in this PR?

I see it's just the one warning; sure it would be great if you could touch that up here :)

@kpp
Copy link
Contributor Author

kpp commented Dec 14, 2021

Done

lloydmeta
lloydmeta approved these changes Dec 17, 2021
View reviewed changes
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lloydmeta lloydmeta merged commit 09a3d4f into lloydmeta:master Dec 17, 2021
@kpp kpp deleted the optimize_semigroup branch December 17, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloydmeta lloydmeta lloydmeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpp @lloydmeta