Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for play 2.9 #13

Merged
merged 1 commit into from Nov 2, 2023
Merged

Update for play 2.9 #13

merged 1 commit into from Nov 2, 2023

Conversation

kijuky
Copy link
Contributor

@kijuky kijuky commented Nov 2, 2023

Summary

Update Play 2.9.x

Detail

  • fix readme
  • fix build.sbt
  • change format scalariform to scalafmt
    • scala xml version up to 2
  • drop java8, and add java17, java21
  • code formatted
library before after remarks
scala 2.13.8, 2.12.15 2.13.12, 3.3.1
sbt 1.7.2 1.9.7
play 2.8.19 2.9.0
scalatest 3.2.15 3.2.17
commons lang3 3.12.0 3.13.0
commons text 1.10.0 1.11.0
sbt-scalariform 1.8.0 (deleted)
sbt-scalafmt 2.5.2
sbt-scoverage 1.9.3 2.0.9

lloydmeta
lloydmeta approved these changes Nov 2, 2023
View reviewed changes
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just waiting for the weekend to merge + release.

@lloydmeta lloydmeta merged commit 0051ea8 into lloydmeta:master Nov 2, 2023
3 checks passed
@lloydmeta
Copy link
Owner

Thanks for this. Just pushed 1.7 with this change.

@kijuky kijuky deleted the feature/play29 branch November 3, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloydmeta lloydmeta lloydmeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kijuky @lloydmeta