Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#69 - API always returns 304 as response from PUT request #79

Merged
merged 2 commits into from
Apr 6, 2014
Merged

#69 - API always returns 304 as response from PUT request #79

merged 2 commits into from
Apr 6, 2014

Conversation

lholman
Copy link
Member

@lholman lholman commented Apr 5, 2014

Modified the InProcProvider initialisation to set a fully qualified assembly name, made similar change to Femah.Core.Femah.SetSwitchType
@hotstone can you take a look please?

…tests again and tweaking a comparison in the ApiResponseBuilder
Modified the InProcProvider initialisation to set a fully qualified assembly name, made similar change to Femah.Core.Femah.SetSwitchType
@lholman
Copy link
Member Author

lholman commented Apr 5, 2014

@hotstone Please make sure you have a read of the original issue here #79

hotstone added a commit that referenced this pull request Apr 6, 2014
#69 - API always returns 304 as response from PUT request
@hotstone hotstone merged commit 326843d into lloydstone:master Apr 6, 2014
@hotstone
Copy link
Contributor

hotstone commented Apr 6, 2014

Yep, that makes sense.

@lholman
Copy link
Member Author

lholman commented Apr 7, 2014

@hotstone thanks for that, could you have another read of this though please? #65 I'd much rather not hit that green auto merge button in the UI any more, what do you think?

@lholman lholman deleted the 69-api-returns-304-from-put branch April 7, 2014 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants