Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the boolean flags in the python scripts #30

Closed
govoni opened this issue Oct 27, 2015 · 4 comments
Closed

fix the boolean flags in the python scripts #30

govoni opened this issue Oct 27, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@govoni
Copy link
Contributor

govoni commented Oct 27, 2015

boolean flags should be set as follows:

http://wingware.com/psupport/python-manual/2.5/lib/optparse-handling-boolean-options.html

@giacomoortona giacomoortona self-assigned this Oct 29, 2015
@giacomoortona giacomoortona added this to the skimming milestone Oct 29, 2015
@l-cadamuro
Copy link
Contributor

Ehm why should we do this? The same boolean flags are used for example here and work fine
https://github.com/LLRCMS/LLRHiggsTauTau/blob/master/NtupleProducer/test/submitOnTier3_LLRHTauTau.py#L47

@govoni
Copy link
Contributor Author

govoni commented Oct 31, 2015

I don't even know why it works elsewhere, but we ended up in a situation, with Olivier, where the thing was not properly working, here:

https://github.com/LLRCMS/KLUBAnalysis/blob/master/scripts/skimNtuple.py#L51

basically the option to run the HHKinFiter is taken as a string, not as a bool.

@l-cadamuro
Copy link
Contributor

Oh yes, indeed I checked and it is true also in the other script we use to submit on the tier3.
But we always used one option as “true” and the other converted to a string so the problem never showed up.
So when we have time it is better to replace with boolean options like --dokinfit and --no-dokinfit etc.

Il giorno 31/ott/2015, alle ore 13:46, Pietro Govoni notifications@github.com ha scritto:

I don't even know why it works elsewhere, but we ended up in a situation, with Olivier, where the thing was not properly working, here:

https://github.com/LLRCMS/KLUBAnalysis/blob/master/scripts/skimNtuple.py#L51 https://github.com/LLRCMS/KLUBAnalysis/blob/master/scripts/skimNtuple.py#L51
basically the option to run the HHKinFiter is taken as a string, not as a bool.


Reply to this email directly or view it on GitHub #30 (comment).

@giacomoortona
Copy link
Contributor

Yes, I was planning to do it after this round of skimming, in order not to mess up with people scripts right now

francescobrivio pushed a commit to francescobrivio/KLUBAnalysis that referenced this issue Aug 10, 2018
MuTau and ETau ID SF only for real tauh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants