Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartfmt may be unnecessary #21

Closed
zgosalvez opened this issue Jan 4, 2021 · 2 comments · Fixed by #22
Closed

dartfmt may be unnecessary #21

zgosalvez opened this issue Jan 4, 2021 · 2 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@zgosalvez
Copy link

run: dartfmt --set-exit-if-changed --dry-run --fix lib test example

Running the dartfmt command in the CI may be unnecessary since

uses: zgosalvez/github-actions-analyze-flutter@v1
already runs it. See https://github.com/zgosalvez/github-actions-analyze-dart/blob/17a5ca792b39421bdaace447ba65be49af8d907d/src/index.js#L96.

@llucax llucax added the enhancement New feature or request label Jan 4, 2021
@llucax llucax added this to the next milestone Jan 4, 2021
@llucax llucax self-assigned this Jan 4, 2021
@llucax
Copy link
Owner

llucax commented Jan 4, 2021

Thanks for the tip! I can't figure it out easily, will it also check the format for test/ and examples/?

@zgosalvez
Copy link
Author

zgosalvez commented Jan 4, 2021

Yes, it checks dart files under the working directory, which includes test/ and example/.

@llucax llucax linked a pull request Jan 4, 2021 that will close this issue
@llucax llucax closed this as completed in #22 Jan 4, 2021
@llucax llucax modified the milestones: next, 0.2.0 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants