Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identified struct types may be const zero-initialized #297

Merged
merged 1 commit into from May 3, 2020
Merged

Identified struct types may be const zero-initialized #297

merged 1 commit into from May 3, 2020

Conversation

andrew-wja
Copy link
Member

Add NamedTypeReference to the set of allowable types in constant zero-initialization (addressing #262)

@andrew-wja
Copy link
Member Author

This build works fine for me when run locally, it looks like Travis is misconfigured at the moment?

This was referenced Apr 14, 2020
Closed
Closed
cocreature
cocreature approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I’ve fixed CI. Can you try rebasing?

@andrew-wja
Add NamedTypeReference to the set of allowable types in constant zero…
42ad736 
…-initialization (addressing #262)

Add NamedTypeReference to the set of allowable types in constant zero-initialization (addressing #262)
@andrew-wja
Copy link
Member Author

Thanks, looks good! I’ve fixed CI. Can you try rebasing?

Done!

@cocreature cocreature merged commit 4eb579a into llvm-hs:llvm-9 May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrew-wja @cocreature