Fix a bug in the cpm65 linker script causing certain addresses not to be relocated. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e address for the initialised zero page isn't absolute --- LOADADDR() returns absolute addresses.
asiekierka
pushed a commit
to asiekierka/llvm-mos-sdk
that referenced
this pull request
Jun 29, 2023
…e address (llvm-mos#112) for the initialised zero page isn't absolute --- LOADADDR() returns absolute addresses. Co-authored-by: dg <dg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fallout from #106; turns out that LOADADDR() addresses are absolute. This meant that any address sourced from LOADADDR() doesn't get relocated, even when they should be. Specifically, this was causing the source for the initialised zero page to be read from the wrong location.
The solution is to use a pointer difference of LOADADDRs from the start of the binary to get the offset, and then add on the ADDR of the binary start, turning the symbol into a .text address.