Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VERA FX registers to cx16.h #207

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Added VERA FX registers to cx16.h #207

merged 1 commit into from
Sep 21, 2023

Conversation

ToboterXP
Copy link
Contributor

No comments on the registers, because they're quite complicated

mysterymath
mysterymath approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@mysterymath mysterymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This LGTM, but I'll want to wait on the cc65 version to merge; they may have comments, and our implementation should match theirs as far as possible.

@mysterymath
Copy link
Member

TODO: Watch cc65/cc65#2196

@mysterymath
Copy link
Member

Apparently they take a lot longer than we do on PRs, so I'm happy to be the first to take this in. We can adjust things later if need be. LGTM!

@mysterymath mysterymath merged commit cbe12f6 into llvm-mos:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysterymath mysterymath mysterymath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ToboterXP @mysterymath