Disable diagnostics ANSI color for non-terminal #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If stdout is not a terminal device, don't color the output. Alternative considered: * Use [IsTTY](https://github.com/dduan/istty). * Add a auto color option
dduan
added a commit
that referenced
this pull request
Nov 26, 2019
The change from #13 actually disabled coloring when output device is a TTY device. Excerpt from BSD manual for `isatty`: ``` RETURN VALUES The isatty() function returns 1 if fd refers to a terminal type device; otherwise, it returns 0 and may set errno to indicate the error. ``` :facepalm: Anyways.
dduan
added a commit
that referenced
this pull request
Nov 26, 2019
The change from #13 actually disabled coloring when output device is a TTY device. Excerpt from BSD manual for `isatty`: ``` RETURN VALUES The isatty() function returns 1 if fd refers to a terminal type device; otherwise, it returns 0 and may set errno to indicate the error. ``` Double negative is hard. 🤦♀️ Anyways.
Merged
dduan
added a commit
that referenced
this pull request
Nov 26, 2019
The change from #13 actually disabled coloring when output device is a TTY device. Excerpt from BSD manual for `isatty`: ``` RETURN VALUES The isatty() function returns 1 if fd refers to a terminal type device; otherwise, it returns 0 and may set errno to indicate the error. ``` Double negative is hard. 🤦♀️ Anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If stdout is not a terminal device, don't color the output. This makes output in Vim quickfix buffer look much better since currently they are currently interleaved with ANSI code.
Alternative considered: