Skip to content

Commit

Permalink
[OM] Add dependencies from Evaluator library to generated headers.
Browse files Browse the repository at this point in the history
The Evaluator depends on the headers, so the dependency should be
declared explicitly. The LINK_LIBS dependency on CIRCTOM doesn't
guarantee the headers will be generated before the Evaluator is
compiled, which can randomly cause build failures.

Should fix #5346.
  • Loading branch information
mikeurbach committed Jun 9, 2023
1 parent 6928392 commit a2bf8ed
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions lib/Dialect/OM/Evaluator/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
add_circt_library(CIRCTOMEvaluator
Evaluator.cpp

DEPENDS
MLIROMIncGen
MLIROMAttrIncGen

LINK_LIBS
CIRCTOM
MLIRIR
Expand Down

1 comment on commit a2bf8ed

@teqdruid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the problem. Thanks for giving it attention so quickly!

Please sign in to comment.