-
Notifications
You must be signed in to change notification settings - Fork 278
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AddSeqMemPorts] Add hierpathop to verbatim, instead of raw instance…
… path (#7014) The annotation `AddSeqMemPortsFileAnnotation` causes the pass `AddSeqMemPort` to add verbatim ops for the SRAM metadata file. The file lists each SRAM and provides the mapping to where it is in the hierarchy, and gives its IO prefix at the DUT top level. This PR updates the pass to use `HierPathOp` to print the SRAM instance path, instead of the raw list of symbol references. This is required to ensure that the instance path is valid, even if the hierarchy is updated by following passes. This fixes a `firtool` crash that is exposed when using `AddSeqMem` along with `ExtractSeqMem`. Which is due to invalid symbol references in the `varbatim`, after the hierarchy was updated. Even though, this particular use case is invalid, as these two SRAM annotations cannot be used together, it can still be triggered by other transformations. Note: This metadata will soon be moved to OM, in a followup PR.
- Loading branch information
Showing
2 changed files
with
55 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters