Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Add and flattening case, or, xor idempotency case. #114

Merged
merged 9 commits into from
Oct 4, 2020

Conversation

cgyurgyik
Copy link
Member

No description provided.

@cgyurgyik cgyurgyik added the HW Involving the `hw` dialect label Oct 3, 2020
@cgyurgyik cgyurgyik requested review from drom and lattner October 3, 2020 20:46
Copy link
Collaborator

@lattner lattner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

lib/Dialect/RTL/Ops.cpp Outdated Show resolved Hide resolved
lib/Dialect/RTL/Ops.cpp Show resolved Hide resolved
@drom
Copy link
Contributor

drom commented Oct 3, 2020

A proper idempotency still blocked by https://bugs.llvm.org/show_bug.cgi?id=47639
And discussed here: #85 (comment)
How could we escalate MLIR fix?

@cgyurgyik cgyurgyik changed the title [RTL] Add and flattening case, or idempotency case. [RTL] Add and flattening case, or, xor idempotency case. Oct 4, 2020
@lattner
Copy link
Collaborator

lattner commented Oct 4, 2020

A proper idempotency still blocked by https://bugs.llvm.org/show_bug.cgi?id=47639
And discussed here: #85 (comment)
How could we escalate MLIR fix?

MLIR is an open source projects, so the proper response from it is "patches welcome". I'm not sure if I'll get cycles, but I'll take a crack at it at some point.

lib/Dialect/RTL/Ops.cpp Show resolved Hide resolved
lib/Dialect/RTL/Ops.cpp Outdated Show resolved Hide resolved
lib/Dialect/RTL/Ops.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@lattner lattner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great with the change to xor(x,x)

@cgyurgyik
Copy link
Member Author

cgyurgyik commented Oct 4, 2020

Looking great with the change to xor(x,x)

Done. Thanks for working through this patiently with me.

Edit: Merged before the integration tests finished. I'll confirm they finish successfully.

@cgyurgyik cgyurgyik merged commit e9f435d into llvm:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HW Involving the `hw` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants