[RTL] Adding struct, union, and enum types to the RTL dialect #124
Conversation
|
Waiting on #117 to compile and run successfully. |
teqdruid
force-pushed
the
rtl-agg-types
branch
from
4170019
to
37feea7
Compare
teqdruid
changed the title
Testing the clang-tidy fix on the PR in which I discovered the bug.
clang-tidy-diff aparantly only looks for the build database if there are revelant changes in the diff.
| {exInt, i1}, | ||
| {exFP, f32} | ||
| > | ||
| !exStruct2 = type !rtl.struct<{sint2, si2}, {float1, f32}> |
There was a problem hiding this comment.
Should the field names be quoted?
There was a problem hiding this comment.
Personally, I prefer no quotes, and parsing them with parseKeyword. That does preclude some strings, but IMO those strings would not make readable field names. Perhaps there is a need for the names to be machine-generated where it would be better to quote it?
| static Type parseFieldInfoType(MLIRContext *ctxt, DialectAsmParser &parser) { | ||
| SmallVector<FieldInfo, 4> parameters; | ||
| if (parser.parseLess()) | ||
| return ::mlir::Type(); |
There was a problem hiding this comment.
i don't think we need the ::mlir:: prefix since we're using namespace mlir
| {exInt, i1}, | ||
| {exFP, f32} | ||
| > | ||
| !exStruct2 = type !rtl.struct<{sint2, si2}, {float1, f32}> |
There was a problem hiding this comment.
Personally, I prefer no quotes, and parsing them with parseKeyword. That does preclude some strings, but IMO those strings would not make readable field names. Perhaps there is a need for the names to be machine-generated where it would be better to quote it?
No description provided.