[SSP] Add SSP <-> circt::scheduling conversion utilities. #3636
Conversation
| ArrayAttr saveInstanceProperties(ProblemT &prob, ImplicitLocOpBuilder &b) { | ||
| SmallVector<Attribute> props; | ||
| Attribute prop; | ||
| ((prop = InstancePropertyTs::getFromProblem(prob, b.getContext()), |
There was a problem hiding this comment.
Is this form required? It may just be me, but coming from the LLVM coding standards, it seems a little dense and surprising. I've never seen the ... in LLVM/MLIR C++ code like this.
There was a problem hiding this comment.
Is this form required?
No, in this case, the alternative would be to have helper templates that unpack the type parameters by recursion.
It may just be me, but coming from the LLVM coding standards, it seems a little dense and surprising.
Funnily, I had the same reaction when I first learned about the fold expressions from @7FM 🤓 However, I find the construct quite neat now. I added comments to point out what's happening.
I've never seen the ... in LLVM/MLIR C++ code like this.
Fold expressions are a C++17 feature, but people would like to use them in the future.
There was a problem hiding this comment.
Got it, if this is a new, well understood c++17 feature, then sounds good to me. Glad we have the ability to use the "new" stuff in CIRCT.
This PR adds the missing pieces to link the SSP dialect to the scheduling infra.
NB: It's debatable whether the
-ssp-roundtrippass should live with the other scheduling test passes. I mostly put it in there because SSP doesn't have the pass boilerplate yet. However, my current plan is to rework all of this anyways, and replace the test passes with a (public)-schedulepass to operate on SSP IR.