[Python] Add CMake for MacOS C++17 compatibility in wheel build. #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using C++17, and a recent addition to the Python bindings for the OM dialect relies on a C++17 feature. For this to compile with pybind11, we need to ensure we set the -mmacosx-version-min flag to at least version 10.14, which is where support for these C++17 features became available. By default, CMake was detecting an older version, so explicitly set this when building the wheel.
|
Passing wheel build that I manually triggered on this branch here: https://github.com/llvm/circt/actions/runs/5215465013. |
rsetaluri
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using C++17, and a recent addition to the Python bindings for the OM dialect relies on a C++17 feature. For this to compile with pybind11, we need to ensure we set the -mmacosx-version-min flag to at least version 10.14, which is where support for these C++17 features became available. By default, CMake was detecting an older version, so explicitly set this when building the wheel.