[OM] Get the field names from an Object #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teqdruid
reviewed
Jun 20, 2023
| @@ -55,6 +56,18 @@ struct Object { | |||
| return omEvaluatorObjectValueGetPrimitive(result); | |||
| } | |||
|
|
|||
| // Get a list with the names of all the fields in the Object. | |||
| std::vector<std::string> getFieldNames() { | |||
| ArrayAttr fieldNames = | |||
There was a problem hiding this comment.
You cannot use ArrayAttr in pybind11 code. You must use the CAPI for interacting with MLIR objects/classes... 'cause linking issues.
| cast<ArrayAttr>(unwrap(omEvaluatorObjectGetFieldNames(object))); | ||
|
|
||
| std::vector<std::string> slots; | ||
| for (auto fieldName : fieldNames.getAsRange<StringAttr>()) |
There was a problem hiding this comment.
Oh sorry, didn't realize that, will create a new PR to fix it.
There was a problem hiding this comment.
@prithayan no worries, it was my bad, and fixed in 80531eb
|
Mike already fixed it. Thanks!
…On Tue, Jun 20, 2023, 6:09 PM Prithayan Barua ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/Bindings/Python/OMModule.cpp
<#5402 (comment)>:
> @@ -55,6 +56,18 @@ struct Object {
return omEvaluatorObjectValueGetPrimitive(result);
}
+ // Get a list with the names of all the fields in the Object.
+ std::vector<std::string> getFieldNames() {
+ ArrayAttr fieldNames =
+ cast<ArrayAttr>(unwrap(omEvaluatorObjectGetFieldNames(object)));
+
+ std::vector<std::string> slots;
+ for (auto fieldName : fieldNames.getAsRange<StringAttr>())
Oh sorry, didn't realize that, will create a new PR to fix it.
—
Reply to this email directly, view it on GitHub
<#5402 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALNXYCAMEKWFGTNV3VUHPLXMJCV3ANCNFSM6AAAAAAZGW3X34>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the API to get the field names and iterate over an object.