[OM] Expose ReferenceAttr to Python #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Looks great, thanks for adding this. Do you mind adding a test in https://github.com/llvm/circt/blob/main/integration_test/Bindings/Python/dialects/om.py?
nandor
force-pushed
the
dev/nandor/om-reference
branch
from
5454585
to
b2dc38e
Compare
nandor
force-pushed
the
dev/nandor/om-reference
branch
from
b2dc38e
to
f0ee0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the reference attribute and inner name ref chain to a Python tuple for OM object evaluation.