[OM] Add om.list_create to create lists of objects
#5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
reviewed
Jun 16, 2023
| ListType:$result | ||
| ); | ||
|
|
||
| let hasCustomAssemblyFormat = 1; |
There was a problem hiding this comment.
Would it be possible to use the result type in the textual form and use the assembly format in ODS? Eh on second thought this is how hw.array_create works, so this seems fine. It would still be nice to use the assembly format string in ODS, if it's possible to extract the type of the first operand in ODS.
There was a problem hiding this comment.
I think we should keep this in sync with hw.array_create. I don't know how to get ODS to specify the element type and check. I am pretty sure we can build a constraint to validate that arguments match the element type of an array, but then we'd have to specify the full list type for the list.
uenoku
reviewed
Jun 16, 2023
uenoku
reviewed
Jun 16, 2023
nandor
force-pushed
the
dev/nandor/om-list
branch
from
67b6733
to
e0f0949
Compare
uenoku
reviewed
Jun 16, 2023
nandor
force-pushed
the
dev/nandor/om-list
branch
from
e0f0949
to
f3990e9
Compare
darthscsi
approved these changes
Jul 31, 2023
mikeurbach
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the op to create lists of objects.
The Python bindings are not yet implemented as further discussion of the in-memory representation is required.