Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] Add a 'by-name' lookup for HWModuleLike ops #5473

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

mortbopet
Copy link
Contributor

... based on a name-to-index DenseMap built from the hw::ModulePortInfo struct. Needed in various places, and not willing to wait for #5350.

... based on a name-to-index `DenseMap` built from the `hw::ModulePortInfo` struct.
Needed in various places, and not willing to wait for #5350.
@mortbopet mortbopet force-pushed the dev/mpetersen/hw_mod_by_name branch from e55b766 to d79a544 Compare June 27, 2023 07:49
@mortbopet mortbopet requested a review from mikeurbach July 4, 2023 07:22
Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mortbopet mortbopet merged commit d658874 into main Jul 5, 2023
5 checks passed
calebmkim pushed a commit to andrewb1999/circt that referenced this pull request Jul 12, 2023
... based on a name-to-index `DenseMap` built from the `hw::ModulePortInfo` struct.
Needed in various places, and not willing to wait for llvm#5350.
@darthscsi darthscsi deleted the dev/mpetersen/hw_mod_by_name branch June 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants