Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL][FIRParser] Rework assert+FALLTHROUGH, NFCI. #5505

Merged
merged 1 commit into from
Jun 28, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/Dialect/FIRRTL/Import/FIRParser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,8 @@ class FIRParser::LocWithInfo {
using ILH = FIRParserOptions::InfoLocHandling;
switch (parser->constants.options.infoLocatorHandling) {
case ILH::IgnoreInfo:
assert(0 && "Should not parse info locations if ignoring");
LLVM_FALLTHROUGH;
assert(0 && "Should not return info locations if ignoring");
break;
case ILH::PreferInfo:
infoLoc = loc;
break;
Expand Down Expand Up @@ -1360,8 +1360,9 @@ struct LazyLocationListener : public OpBuilder::Listener {
using ILH = FIRParserOptions::InfoLocHandling;
switch (parser.getConstants().options.infoLocatorHandling) {
case ILH::IgnoreInfo:
assert(0 && "Should not parse info locations if ignoring");
LLVM_FALLTHROUGH;
// Shouldn't have an infoLoc, but if we do ignore it.
opAndSMLoc.first->setLoc(parser.translateLocation(opAndSMLoc.second));
break;
case ILH::PreferInfo:
opAndSMLoc.first->setLoc(infoLoc);
break;
Expand Down