Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HW][SV] Move string type from SV to HW #5588

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[HW][SV] Move string type from SV to HW #5588

merged 1 commit into from
Jul 14, 2023

Conversation

teqdruid
Copy link
Contributor

@teqdruid teqdruid commented Jul 14, 2023 •
edited
Loading

Closes #5576.

Moving this since in the (near) future the verif dialect and HW module parameterization will be using string types.

@teqdruid teqdruid added HW Involving the `hw` dialect Verilog/SystemVerilog Involving a Verilog dialect labels Jul 14, 2023
fabianschuiki
fabianschuiki approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teqdruid teqdruid merged commit c21077b into main Jul 14, 2023
5 checks passed
@teqdruid teqdruid deleted the dev/teqdruid/string branch July 14, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianschuiki fabianschuiki fabianschuiki approved these changes

Assignees
No one assigned
Labels
HW Involving the `hw` dialect Verilog/SystemVerilog Involving a Verilog dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HW] String type
2 participants
@teqdruid @fabianschuiki