-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowners for Calyx #5631
Add codeowners for Calyx #5631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Happy to be a Calyx code owner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
I'll add myself for CalyxToHW, since I added at least the initial version of that pass. I will also be happy to be added on LoopScheduleToCalyx, since I worked on the parts that are different from SCFToCalyx. I can add myself in a future commit, or if this PR is updated, feel free to add me.
@mortbopet - would you be willing to be added as a codeowner for SCFToCalyx with me? I have some familiarity, but sometimes I need to ask your opinion anyway.
@mikeurbach (and everyone else) Please feel free to add yourself to relevant things. I didn't have all of the interest overlaps in my mind so definitely missed some things |
(Added @mikeurbach to HW and LoopSchedule) |
@mikeurbach Yea, sign me up for SCFToCalyx. |
@mortbopet done with the changes. Looks like we have consensus on the ownership! Let's merge if there are no more changed needed |
This looks ready to merge, would you like to do the honors @rachitnigam ? |
Fixes #5543.
Attempt to allocate the owners based on previous file commit histories for now. My suggestion is that we keep it pretty liberal going forward so that people can take ownership of various passes as they evolve.