Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners for Calyx #5631

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Add codeowners for Calyx #5631

merged 3 commits into from
Aug 1, 2023

Conversation

rachitnigam
Copy link
Contributor

Fixes #5543.

Attempt to allocate the owners based on previous file commit histories for now. My suggestion is that we keep it pretty liberal going forward so that people can take ownership of various passes as they evolve.

Copy link
Contributor

@andrewb1999 andrewb1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to be a Calyx code owner.

Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all

Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

I'll add myself for CalyxToHW, since I added at least the initial version of that pass. I will also be happy to be added on LoopScheduleToCalyx, since I worked on the parts that are different from SCFToCalyx. I can add myself in a future commit, or if this PR is updated, feel free to add me.

@mortbopet - would you be willing to be added as a codeowner for SCFToCalyx with me? I have some familiarity, but sometimes I need to ask your opinion anyway.

@rachitnigam
Copy link
Contributor Author

@mikeurbach (and everyone else) Please feel free to add yourself to relevant things. I didn't have all of the interest overlaps in my mind so definitely missed some things

@rachitnigam
Copy link
Contributor Author

(Added @mikeurbach to HW and LoopSchedule)

@mortbopet
Copy link
Contributor

@mikeurbach Yea, sign me up for SCFToCalyx.
@rachitnigam please remove me as a codeowner for Calyx - it's not that i don't want to be part of Calyx discussions and PRs, it moreso that I'm trying to spread out the burden of codeownership in CIRCT, and not have my name on too many different things and dialects (which will increase in the near future...).

@rachitnigam
Copy link
Contributor Author

@mortbopet done with the changes. Looks like we have consensus on the ownership! Let's merge if there are no more changed needed

@dtzSiFive
Copy link
Contributor

This looks ready to merge, would you like to do the honors @rachitnigam ?

@rachitnigam rachitnigam merged commit cab1421 into main Aug 1, 2023
5 checks passed
@darthscsi darthscsi deleted the calyx-codeowners branch June 4, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Calyx] Missing codeowner
7 participants