[HW][HWModules] Add ability to set/erase port symbols. #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be added to an interface shared elsewhere, (and with different signature suitable to per-field syms) but for now keep this on the HW module ops. The `hw.exportPort` string literal is used on HW ops to store the inner symbol (`getArgSym`, so on). Also, since the code for HWModule ops in particular already hardcodes use of `hw.exportPort`, change the getter to look for the port symbol under that name specifically.
rwy7
approved these changes
Jul 31, 2023
|
cc @darthscsi and @youngar re:touching/thinking about these things, esp in HW. Post-merge review/thoughts welcome 👍 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be added to an interface shared elsewhere, (and with different signature suitable to per-field syms) but for now keep this on the HW module ops.
The
hw.exportPortstring literal is used on HW ops to store the inner symbol (getArgSym, so on).Also, since the code for HWModule ops in particular already hardcodes use of
hw.exportPort, change the getter to look for the port symbol under that name specifically.