[OM] Implement OM linker pass #5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements LinkModulesPass that is a core logic of `om-linker`. The input IR consists of multiple mlir::ModuleOp that have their own symbol namespaces. We consider a symbol used as an external module to be "public" thus we cannot rename such symbols when symbols collide. We require a public symbol to have exactly one definition so otherwise raise an error.
uenoku
force-pushed
the
dev/uenoku/om-linker-pass
branch
from
17835e4
to
2f0e1dd
Compare
mikeurbach
reviewed
Aug 1, 2023
This commit implements a stricter check for class resolution. This commit forbids linking between classes with different fields.
uenoku
force-pushed
the
dev/uenoku/om-linker-pass
branch
from
460bee0
to
655ddb4
Compare
mikeurbach
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements LinkModulesPass that is a core logic of
om-linker. The input IR consists of multiple mlir::ModuleOp that have their own symbol namespaces.We consider a symbol used as an external module to be "public" thus we cannot rename such symbols when symbols collide. We require a public symbol to have exactly one definition so otherwise raise an error.