Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVExtractTestCode] Inline input only modules even when no operation … #5771

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Aug 3, 2023

…is extracted

Currently we only inline input only modulse when op is extracted. However if a module only contains input only modules there might be no extraction and hence we might end up having input only modules.

…is extracted

Currently we only inline input only modulse when op is extracted.
However if a module only contains input only modules there might
be no extraction and hence we might end up having input only modules.
@uenoku uenoku requested a review from mikeurbach August 3, 2023 08:34
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@uenoku uenoku merged commit 344a5ac into main Aug 3, 2023
5 checks passed
@uenoku uenoku deleted the dev/uenoku/inline-input-only-modules-e branch August 3, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants