[Handshake] Add StaticLogic Dialect and Pipeline Operation #62
Conversation
| let cppNamespace = ""; | ||
| } | ||
|
|
||
| def PipelineOp : Op<StaticLogic_Dialect, "pipeline", [FunctionLike, Symbol, |
There was a problem hiding this comment.
Why FunctionLike? I was thinking that this was just a region inside the op.
There was a problem hiding this comment.
I see. My thinking was all kinds of statically scheduled operations should be separate modules. But actually this isolation is not necessary to happen until further lowering these operations down to FIRRTL or etc. Before that, the pipeline operation is just kind of annotation and keeping things simple will make it easier to modify the pipeline structure.
There was a problem hiding this comment.
Even when lowering to FIRRTL, making them separate modules seems to be optional as well.
| /// This function converts all live-ins of a block into its arguments, and | ||
| /// converts all live-outs of a block into its return values. In this way, the | ||
| /// sequencial code inside of each block can be isolated and converted to a | ||
| /// function call. |
There was a problem hiding this comment.
This seems similar to the live variables analysis in StandardToHandshake. Perhaps this should get factored out rather than duplicating it again? Hmm... is this even required or can we just leave the flow between pipeline stages implicit as long as the blocks are a linear chain?
There was a problem hiding this comment.
Yes, we can definitely factor this out as kind of canonicalization.
Since we will not isolate the pipeline operation as a function-like region, this analysis is no more necessary. We can just leave them implicit and all these stuff will happen automatically in the standard-to-handshake pass.
…s; update testcase
…not single-producer single-consumer; update test case.
|
For accommodating the standard-to-handshake lowering, the pipeline region is still isolated from above in this new version. If this is the case, I feel whether the pipeline operation is function-like or not doesn't have distinct differences. Live-in/out analysis is removed, thus some flows between pipeline operations become implicit, and will not be handled until the standard-to-handshake lowering. |
This patch introduces an experimental StaticLogic dialect for representing statically scheduled modules (e.g. a pipeline). For now, a pipeline operation and a simple lowering pass, which can convert sequential codes in each block into a pipeline operation, are designed in the StaticLogic dialect.